Summary: | Remove multi-threading gunk from WebKit2's PluginInfoStore. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | Plug-ins | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, buildbot, cdumez, kling, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 110053 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Andreas Kling
2013-02-16 21:11:36 PST
Created attachment 188753 [details]
Patch
Comment on attachment 188753 [details] Patch Attachment 188753 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16590745 New failing tests: media/video-controls-captions-trackmenu.html Committed r143124: <http://trac.webkit.org/changeset/143124> The output of plugins/plugin-javascript-access.html changed after this patch it seems: --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/plugins/plugin-javascript-access-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/plugins/plugin-javascript-access-actual.txt @@ -1,3 +1,37 @@ +Name: WebKit Test PlugIn + +Description: Simple Netscape® plug-in that handles test content for WebKit + +Filename: libTestNetscapePlugin.so + +Mime Types: + +Type: application/x-webkit-test-netscape + +Description: test netscape content + +Suffixes: testnetscape + + +Plugin.item() works. + +Plugin.namedItem() works. + +Type: image/png + +Description: png image + +Suffixes: png + + +Plugin.item() works. + +Plugin.namedItem() works. + +PluginArray.item() works. + +PluginArray.namedItem() works. + Name: WebKit Test PlugIn Description: Simple Netscape® plug-in that handles test content for WebKit @@ -41,3 +75,13 @@ MimeTypeArray.item() works. MimeTypeArray.namedItem() works. + +Type: application/x-webkit-test-netscape + +Description: test netscape content + +Suffixes: testnetscape + +MimeTypeArray.item() works. + +MimeTypeArray.namedItem() works. Based on the patch description, I would not expect the behavior to change. Any idea why this happens? I uploaded a fix for the regression at Bug 110053. |