Bug 110044

Summary: Deprecate canvas.webkitLineDash and canvas.webkitLineDashOffset
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CanvasAssignee: Dirk Schulze <krit>
Status: NEW    
Severity: Normal CC: abarth, ahmad.saleem792, buildbot, dino, karlcow, mkwst+watchlist, ojan.autocc, rniwa, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+, buildbot: commit-queue-

Dirk Schulze
Reported 2013-02-16 17:39:46 PST
Deprecate canvas.webkitLineDash and canvas.webkitLineDashOffset and throw warnings.
Attachments
Patch (9.63 KB, patch)
2013-02-16 17:43 PST, Dirk Schulze 		abarth: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2013-02-16 17:43:40 PST
Created attachment 188747 [details] Patch
Build Bot
Comment 2 2013-02-17 01:17:00 PST
Comment on attachment 188747 [details] Patch Attachment 188747 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16549056 New failing tests: inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html media/video-controls-captions-trackmenu.html inspector/profiler/canvas2d/canvas2d-gradient-capturing.html
Build Bot
Comment 3 2013-02-19 05:10:08 PST
Comment on attachment 188747 [details] Patch Attachment 188747 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16608824 New failing tests: inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html inspector/profiler/canvas2d/canvas2d-gradient-capturing.html
Mike West
Comment 4 2013-02-19 05:23:49 PST
Comment on attachment 188747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188747&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:554 > + (ASCIILiteral("The attribute webkitLineDash is deprecated. Please use the methods setLineDash and getLineDash instead."))); For consistency with other messages, I'd suggest putting code inside quotes. That is, "The attribute 'webkitLineDash' is deprecated...". > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:584 > + (ASCIILiteral("The attribute webkitLineDashOffset is deprecated. Please use the attriubte lineDashOffset instead."))); Nit: There's a typo in the second occurance of 'attribute'. :) This also might sound slightly better as "The 'webkitLineDashOffset' attribute is deprecated. Please use 'lineDashOffset' instead." > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:593 > + (ASCIILiteral("The attribute webkitLineDashOffset is deprecated. Please use the attriubte lineDashOffset instead."))); Ditto.
Dirk Schulze
Comment 5 2019-10-22 06:50:58 PDT
WebKit still has canvas.webkitLineDash. Is this bug still relevant? Do we need to give the deprecation warning still?
Note You need to log in before you can comment on or make changes to this bug.