Summary: | font-size: 0 is ignored | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||||||
Component: | CSS | Assignee: | Dave Hyatt <hyatt> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, ademar, ap, eric, hyatt, moz, suresh.voruganti, webkit, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | GoogleBug, InRadar | ||||||||||||
Version: | 420+ | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.4 | ||||||||||||||
URL: | http://mail.google.com/mail/ | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 52765 | ||||||||||||||
Attachments: |
|
Description
mitz
2006-09-24 02:20:51 PDT
Created attachment 10731 [details]
Safari layout
Created attachment 10732 [details]
Safari layout, text selected
Created attachment 10733 [details]
Firefox layout
What a lame hack. Created attachment 10745 [details]
Patch.
Looks like we get a 1px rendering when specifying 0. I think AppKit or someone is doing that.
Comment on attachment 10745 [details]
Patch.
You need a test case and a ChangeLog, otherwise fine.
r=me
Dave you should change the WebKitMinimumFontSizePreferenceKey default to 0, right now it is 1. Was this where the 1px render came from? There's still some debate going on, which is why i haven't marked fixed yet (or done the test). I think I'm going to back out the pref change and just keep it at 1 (so we'll match WinIE). Comment on attachment 10745 [details]
Patch.
Clearing r+ to keep this from showing up in the commit queue. Leaving the bug open pending a layout test.
IMO bug 13891 is related to this bug. The bug is related to bug 15086. *** Bug 39148 has been marked as a duplicate of this bug. *** What's the status of this bug? Per comment 8, it was fixed, but the behavior is still the same according to the above duplicate. Created attachment 74044 [details]
Patch
Fixed in r72141. *** Bug 49582 has been marked as a duplicate of this bug. *** http://trac.webkit.org/changeset/72141 might have broken Leopard Intel Debug (Tests) Pls cherry pick the fix to Qtwebkit 2.1.x branch because this patch fixes failure "First rectangle shows two colors when accessing a link on CSS 3 color public test suite." in QtTestBrowser in Symbian. (In reply to comment #20) > Pls cherry pick the fix to Qtwebkit 2.1.x branch because this patch fixes failure > "First rectangle shows two colors when accessing a link on CSS 3 color public test suite." in QtTestBrowser in Symbian. r72141 is too risky and complex to be added to qtwebkit-2.1.x. When it landed on trunk, it introduced several small regressions (see, for example, bug 49846, bug 49638, bug 52765 and bug 52265, plus other references in the git log). A backport would be needed and substantial Q&A to minimize the risk of regressions. Since this is not part of the qtwebkit-2.1.x scope and is marked as "nice-to-have", I'm removing it from the meta-bug. |