Bug 110034

Summary:

Need a bundle SPI to generate a snapshot of a specific DOM node

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Sam Weinig 2013-02-16 15:16:17 PST

Need a bundle SPI to generate a snapshot of a specific DOM node

Comment 1 Sam Weinig 2013-03-18 16:57:18 PDT

Created attachment 193693 [details]
Patch

Comment 2 Tim Horton 2013-03-18 17:02:07 PDT

Comment on attachment 193693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193693&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:32
> -- (WKBundleNodeHandleRef)_copyWKBundleNodeHandleRef;
> +- (WKBundleNodeHandleRef)_copyBundleNodeHandleRef;

Is nobody going to mind this?

> Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:132
> +    OwnPtr<WebCore::GraphicsContext> graphicsContext = snapshot->bitmap()->createGraphicsContext();

Drop the WebCore::, I think.

Comment 3 Sam Weinig 2013-03-18 17:06:08 PDT

(In reply to comment #2)
> (From update of attachment 193693 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193693&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:32
> > -- (WKBundleNodeHandleRef)_copyWKBundleNodeHandleRef;
> > +- (WKBundleNodeHandleRef)_copyBundleNodeHandleRef;
> 
> Is nobody going to mind this?

It was mismatched from the implementation :(.

> 
> > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:132
> > +    OwnPtr<WebCore::GraphicsContext> graphicsContext = snapshot->bitmap()->createGraphicsContext();
> 
> Drop the WebCore::, I think.

K.

Comment 4 Sam Weinig 2013-03-18 17:22:04 PDT

Committed r146154: <http://trac.webkit.org/changeset/146154>