Bug 110033

Summary:

Element: Devirtualize attribute synchronization functions.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Andreas Kling 2013-02-16 15:16:03 PST

There's no reason for Element::updateStyleAttribute() and Element::updateAnimatedSVGAttribute() to be virtual.

Comment 1 Andreas Kling 2013-02-16 15:20:45 PST

Created attachment 188731 [details]
Patch

Comment 2 Darin Adler 2013-02-16 15:27:27 PST

Comment on attachment 188731 [details]
Patch

Not sure it’s ideal to have “synchronize attribute” as the name for both the smart function and the one that should only be called if the attribute is known dirty. I guess I am the one who told you to remove “if needed”, and I still stand by that.

Comment 3 Andreas Kling 2013-02-16 15:36:20 PST

Committed r143114: <http://trac.webkit.org/changeset/143114>