Bug 109957

Summary:

Remove const from a bunch of StorageArea member functions

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, darin, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bdakin: review+

Description Anders Carlsson 2013-02-15 11:25:59 PST

Remove const from a bunch of StorageArea member functions

Comment 1 Anders Carlsson 2013-02-15 11:27:51 PST

Created attachment 188606 [details]
Patch

Comment 2 Andreas Kling 2013-02-15 11:55:49 PST

I think that this removes useful documentation from the code about which functions on the StorageArea interface are conceptually read-only. :(

Comment 3 Anders Carlsson 2013-02-15 11:59:01 PST

(In reply to comment #2)
> I think that this removes useful documentation from the code about which functions on the StorageArea interface are conceptually read-only. :(

I don’t think it makes much sense to use const for an abstract class where implementations can do pretty much anything. That’s the reason why none of our client member functions are const.

Comment 4 Anders Carlsson 2013-02-15 12:07:33 PST

Committed r143031: <http://trac.webkit.org/changeset/143031>