Bug 109919

Summary: Web Inspector: Merge Debug and Tip message levels.
Product: WebKit Reporter: Dmitry Zvorygin <zvorygin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, dglazkov, eric.carlson, esprehn+autocc, feature-media-reviews, fishd, jamesr, japhet, keishi, loislo, macpherson, menard, mkwst+watchlist, ojan.autocc, pfeldman, pmuellr, tkent+wkapi, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dmitry Zvorygin
Reported 2013-02-15 03:26:55 PST
Merge "Debug" and "Tip" message levels, since most of components using any of this message levels use only either Tip or Debug.
Attachments
Patch (15.49 KB, patch)
2013-02-19 06:38 PST, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Patch (15.46 KB, patch)
2013-02-19 06:41 PST, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Patch (15.44 KB, patch)
2013-02-21 04:28 PST, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Patch (15.41 KB, patch)
2013-02-26 07:29 PST, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dmitry Zvorygin
Comment 1 2013-02-19 06:38:45 PST
Created attachment 189077 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 06:41:03 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Dmitry Zvorygin
Comment 3 2013-02-19 06:41:23 PST
Created attachment 189078 [details] Patch
Pavel Feldman
Comment 4 2013-02-20 01:43:44 PST
Comment on attachment 189078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189078&action=review > Source/WebKit/chromium/public/WebConsoleMessage.h:40 > + LevelTip = 0, Why is tip not removed?
Dmitry Zvorygin
Comment 5 2013-02-20 02:14:43 PST
Comment on attachment 189078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189078&action=review >> Source/WebKit/chromium/public/WebConsoleMessage.h:40 >> + LevelTip = 0, > > Why is tip not removed? Because chromium code depends on it. I've removed all the usages from both chromium and webkit, but if I remove it before webkit roll, chromium builds start failing. There will be small third changelist, which will remove this very last LevelTip declaration, and remove enum fields wierd reordering. Third changelist should be pushed synchronously in webkit and chromium.
Dmitry Zvorygin
Comment 6 2013-02-21 04:28:15 PST
Created attachment 189508 [details] Patch
WebKit Review Bot
Comment 7 2013-02-22 04:19:08 PST
Comment on attachment 189508 [details] Patch Rejecting attachment 189508 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189508, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16691794
Dmitry Zvorygin
Comment 8 2013-02-26 07:29:31 PST
Created attachment 190279 [details] Patch
WebKit Review Bot
Comment 9 2013-02-26 08:39:43 PST
Comment on attachment 190279 [details] Patch Clearing flags on attachment: 190279 Committed r144064: <http://trac.webkit.org/changeset/144064>
WebKit Review Bot
Comment 10 2013-02-26 08:39:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.