Bug 109897

Summary: Add setValue and closePopup methods to PagePopupController
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109439    
Description Flags
changed protector position none

Description Keishi Hattori 2013-02-14 23:23:44 PST
In the new calendar picker, we want to set a value without closing the popup.
Comment 1 Keishi Hattori 2013-02-14 23:37:44 PST
Created attachment 188490 [details]
Comment 2 Kent Tamura 2013-02-14 23:57:42 PST
Comment on attachment 188490 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=188490&action=review

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:173
> -    RefPtr<DateTimeChooserImpl> protector(this);
>      if (numValue >= 0)
> -        m_client->didChooseValue(stringValue);
> +        setValue(stringValue);
> +    endChooser();
> +}

The protector is required here.  setValue(), which might dispatch some events, can delete 'this'.

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:178
> +    RefPtr<DateTimeChooserImpl> protector(this);
> +    m_client->didChooseValue(value);

The protector makes no sense. We do nothing after didChooseValue, which might dispatch some events.
Also, I'm afraid that we have no ways to avoid calendar picker JavaScript code execution after didChooseValue because event handler might delete the page popup.
Comment 3 Keishi Hattori 2013-02-15 03:50:01 PST
Created attachment 188529 [details]
changed protector position
Comment 4 Kent Tamura 2013-02-15 04:56:14 PST
Comment on attachment 188529 [details]
changed protector position

Comment 5 WebKit Review Bot 2013-02-15 05:38:32 PST
Comment on attachment 188529 [details]
changed protector position

Clearing flags on attachment: 188529

Committed r142987: <http://trac.webkit.org/changeset/142987>
Comment 6 WebKit Review Bot 2013-02-15 05:38:35 PST
All reviewed patches have been landed.  Closing bug.