Bug 109895

Summary: [V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node*
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2013-02-14 23:08:47 PST
Currently an "EventTarget" type in IDL is converted to Node*. This is wrong because there are non-Node interfaces that inherit a EventTarget. We should convert an "EventTarget" type to EventTarget*. This will fix FIXMEs in CodeGeneratorV8.pm.
Attachments
Patch (2.55 KB, patch)
2013-02-14 23:10 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-14 23:10:00 PST
Created attachment 188484 [details] Patch
Adam Barth
Comment 2 2013-02-15 09:06:34 PST
Comment on attachment 188484 [details] Patch Ah, glad toEventTarget was useful!
WebKit Review Bot
Comment 3 2013-02-15 17:25:44 PST
Comment on attachment 188484 [details] Patch Clearing flags on attachment: 188484 Committed r143075: <http://trac.webkit.org/changeset/143075>
WebKit Review Bot
Comment 4 2013-02-15 17:25:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.