Bug 109895 - [V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node*
Summary: [V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 23:08 PST by Kentaro Hara
Modified: 2013-02-15 17:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.55 KB, patch)
2013-02-14 23:10 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-14 23:08:47 PST 
Currently an "EventTarget" type in IDL is converted to Node*. This is wrong because there are non-Node interfaces that inherit a EventTarget. We should convert an "EventTarget" type to EventTarget*. This will fix FIXMEs in CodeGeneratorV8.pm.
Comment 1 Kentaro Hara 2013-02-14 23:10:00 PST 
Created attachment 188484 [details]
Patch
Comment 2 Adam Barth 2013-02-15 09:06:34 PST 
Comment on attachment 188484 [details]
Patch

Ah, glad toEventTarget was useful!
Comment 3 WebKit Review Bot 2013-02-15 17:25:44 PST 
Comment on attachment 188484 [details]
Patch

Clearing flags on attachment: 188484

Committed r143075: <http://trac.webkit.org/changeset/143075>
Comment 4 WebKit Review Bot 2013-02-15 17:25:47 PST 
All reviewed patches have been landed.  Closing bug.