Bug 109885

Summary: [WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: WebKit2Assignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, rniwa, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dongseong Hwang
Reported 2013-02-14 21:04:46 PST
Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it scrollOffset. So this patch corrects this misnaming. In addition, all subclasses of LayerTreeHost don't use the misnamed scrollOffset in scrollNonCompositedContents(), so this patch removes the scrollOffset argument.
Attachments
Patch (17.06 KB, patch)
2013-02-14 21:07 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-02-14 21:07:01 PST
Created attachment 188475 [details] Patch
WebKit Review Bot
Comment 2 2013-02-14 23:16:42 PST
Comment on attachment 188475 [details] Patch Clearing flags on attachment: 188475 Committed r142968: <http://trac.webkit.org/changeset/142968>
WebKit Review Bot
Comment 3 2013-02-14 23:16:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.