Bug 109881

Summary:

Implement RenderGrid::computeIntrinsicLogicalWidths

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jchaffraix, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109880

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	tony: review+, tony: commit-queue-

Description Ojan Vafai 2013-02-14 18:44:44 PST

Implement RenderGrid::computeIntrinsicLogicalWidths

Comment 1 Ojan Vafai 2013-02-14 18:47:35 PST

Created attachment 188464 [details]
Patch

Comment 2 Ojan Vafai 2013-02-14 18:48:14 PST

Bug 109880 was done in preparation for this.

Comment 3 Ojan Vafai 2013-02-15 12:34:01 PST

Created attachment 188619 [details]
Patch

Comment 4 Tony Chang 2013-02-15 12:39:37 PST

Comment on attachment 188619 [details]
Patch

Now that I've seen the code, I think a const_cast of |this| in computeIntrinsicLogicalWidths would be better.  It feels weird to me that placeItemsOnGrid is const.

Comment 5 Ojan Vafai 2013-02-15 13:19:59 PST

Committed r143043: <http://trac.webkit.org/changeset/143043>