Bug 109881

Summary: Implement RenderGrid::computeIntrinsicLogicalWidths
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109880    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch tony: review+, tony: commit-queue-

Ojan Vafai
Reported 2013-02-14 18:44:44 PST
Implement RenderGrid::computeIntrinsicLogicalWidths
Attachments
Patch (4.56 KB, patch)
2013-02-14 18:47 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (5.46 KB, patch)
2013-02-15 12:34 PST, Ojan Vafai 		tony: review+
tony: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2013-02-14 18:47:35 PST
Created attachment 188464 [details] Patch
Ojan Vafai
Comment 2 2013-02-14 18:48:14 PST
Bug 109880 was done in preparation for this.
Ojan Vafai
Comment 3 2013-02-15 12:34:01 PST
Created attachment 188619 [details] Patch
Tony Chang
Comment 4 2013-02-15 12:39:37 PST
Comment on attachment 188619 [details] Patch Now that I've seen the code, I think a const_cast of |this| in computeIntrinsicLogicalWidths would be better. It feels weird to me that placeItemsOnGrid is const.
Ojan Vafai
Comment 5 2013-02-15 13:19:59 PST
Committed r143043: <http://trac.webkit.org/changeset/143043>
Note You need to log in before you can comment on or make changes to this bug.