Bug 109872

Summary: Inspector doesn't show rules from pluginsStyleSheet
Product: WebKit Reporter: Dean Jackson <dino>
Component: Web Inspector (Deprecated)Assignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, joepeck, keishi, loislo, macpherson, menard, ojan.autocc, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit-bug-importer, webkit.review.bot, yurys
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Dean Jackson
Reported 2013-02-14 16:06:09 PST
The inspector doesn't collect the rules from the plugins style sheet.
Attachments
Patch (1.93 KB, patch)
2013-02-14 16:09 PST, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-02-14 16:06:49 PST
<rdar://problem/13220679>
Dean Jackson
Comment 2 2013-02-14 16:09:19 PST
Created attachment 188446 [details] Patch
Darin Adler
Comment 3 2013-02-14 16:44:28 PST
Comment on attachment 188446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188446&action=review > Source/WebCore/css/InspectorCSSOMWrappers.cpp:127 > + collectFromStyleSheetContents(m_styleSheetCSSOMWrapperSet, CSSDefaultStyleSheets::plugInsStyleSheet); No #ifdef needed?
Dean Jackson
Comment 4 2013-02-14 17:13:37 PST
Comment on attachment 188446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188446&action=review >> Source/WebCore/css/InspectorCSSOMWrappers.cpp:127 >> + collectFromStyleSheetContents(m_styleSheetCSSOMWrapperSet, CSSDefaultStyleSheets::plugInsStyleSheet); > > No #ifdef needed? Nope - these default stylesheets are always around (although possibly empty, and can have different content on different ports thanks to #ifdefs in CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement).
Dean Jackson
Comment 5 2013-02-14 17:22:15 PST
Committed r142944: <http://trac.webkit.org/changeset/142944>
Note You need to log in before you can comment on or make changes to this bug.