| Summary: | TokenPreloadScanner should be able to scan CompactHTMLTokens | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, eric, ojan.autocc, philn, rniwa, tonyg, webkit-ews, webkit.review.bot, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 108027 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2013-02-14 14:15:20 PST
Created attachment 188426 [details]
Patch
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16581513 Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16538801 Probably needs moar ifdefs. :) I'd be interested in your review feedback, however. I'll get it to compile before landing. Comment on attachment 188426 [details]
Patch
I'm entertained that you undid my processPossible refactoring. :)
> I'm entertained that you undid my processPossible refactoring. :)
Yeah, sorry about that. I liked it, but it didn't play well with the switch statement.
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16538845 Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16537920 Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16593082 Comment on attachment 188426 [details]
Patch
OK. Ugly switch. :(
Created attachment 188600 [details]
Patch for landing
Comment on attachment 188600 [details] Patch for landing Rejecting attachment 188600 [details] from commit-queue. abarth@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. wat? Comment on attachment 188600 [details] Patch for landing Clearing flags on attachment: 188600 Committed r143020: <http://trac.webkit.org/changeset/143020> All reviewed patches have been landed. Closing bug. |