Bug 109849

Summary:

AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, ddkilzer, dmazzoni, jdiggs, mario, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109986

Bug Blocks:

Attachments:

Description	Flags
patch	ddkilzer: review+, buildbot: commit-queue-
patch for landing	none

chris fleizach

Reported 2013-02-14 11:15:01 PST

We need to split out some of the common routines in WebAccessibilityObject, like how we fetch titles and descriptions, into a shared location so iOS can share it

Attachments
patch (318.82 KB, patch) 2013-02-14 13:54 PST, chris fleizach	ddkilzer: review+ buildbot: commit-queue-	Details Formatted Diff Diff
patch for landing (311.80 KB, patch) 2013-02-15 17:40 PST, chris fleizach	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2013-02-14 13:54:06 PST

Created attachment 188419 [details] patch

Build Bot

Comment 2 2013-02-15 12:16:14 PST

Comment on attachment 188419 [details] patch Attachment 188419 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16585249 New failing tests: platform/mac/accessibility/aria-liveregions-removedelement.html platform/mac/accessibility/aria-listbox-selectedchildren-change.html platform/mac/accessibility/aria-liveregions-notifications-always-sent.html accessibility/aria-invalid.html accessibility/loading-iframe-sends-notification.html accessibility/notification-listeners.html platform/mac/accessibility/aria-liveregions-notifications.html platform/mac/accessibility/aria-liveregions-changedtext.html platform/mac/accessibility/selected-rows-table.html platform/mac/accessibility/aria-liveregion-on-image.html platform/mac/accessibility/textbox-role-reports-notifications.html platform/mac/accessibility/combobox-activedescendant-notifications.html platform/mac/accessibility/aria-liveregions-addedelement.html platform/mac/accessibility/aria-liveregions-changedalt.html platform/mac/accessibility/aria-expanded-notifications.html platform/mac/accessibility/html-slider-indicator.html

David Kilzer (:ddkilzer)

Comment 3 2013-02-15 13:28:09 PST

Comment on attachment 188419 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=188419&action=review r=me > Source/WebCore/ChangeLog:19 > + * accessibility/mac/WebAccessibilityObjectWrapper.h: > + * accessibility/mac/WebAccessibilityObjectWrapper.mm: For shared code between iOS and Mac, we still need to come up with a name. When we do, these files should move a subdirectory named that (like /apple/).

chris fleizach

Comment 4 2013-02-15 16:19:48 PST

http://trac.webkit.org/changeset/143066

David Kilzer (:ddkilzer)

Comment 5 2013-02-15 16:38:50 PST

(In reply to comment #4) > http://trac.webkit.org/changeset/143066 Broke Apple Lion build (at least): http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/3849/steps/compile-webkit/logs/stdio

chris fleizach

Comment 6 2013-02-15 17:40:49 PST

Created attachment 188675 [details] patch for landing

WebKit Review Bot

Comment 7 2013-02-15 21:58:11 PST

Comment on attachment 188675 [details] patch for landing Clearing flags on attachment: 188675 Committed r143098: <http://trac.webkit.org/changeset/143098>

chris fleizach

Comment 8 2013-02-21 09:53:35 PST

http://trac.webkit.org/changeset/143230

Note You need to log in before you can comment on or make changes to this bug.