Bug 109848

Summary: [GTK][AC] Implement matrix transform animation with clutter ac backend
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105699    
Attachments:
Description Flags
Patch
gustavo: commit-queue-
Patch none

ChangSeok Oh
Reported 2013-02-14 11:12:58 PST
This bug handles matrix transform animation with clutter ac backend.
Attachments
Patch (12.38 KB, patch)
2013-02-14 11:50 PST, ChangSeok Oh 		gustavo: commit-queue-
DetailsFormatted DiffDiff
Patch (12.52 KB, patch)
2013-02-19 10:54 PST, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-02-14 11:50:41 PST
Created attachment 188394 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-02-19 06:39:21 PST
Comment on attachment 188394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188394&action=review > Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:459 > + // FIXME: The matrix interpolation api, clutter_matrix_progress of Clutter 1.12 works unexpectedly. > + // So we overwrite it and handle the interpolation of two matrices with TransformationMatrix. Would be good to link to a bug report here.
ChangSeok Oh
Comment 3 2013-02-19 10:54:41 PST
Created attachment 189114 [details] Patch
ChangSeok Oh
Comment 4 2013-02-19 10:56:46 PST
Comment on attachment 188394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188394&action=review Thanks for the review! >> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:459 >> + // So we overwrite it and handle the interpolation of two matrices with TransformationMatrix. > > Would be good to link to a bug report here. Reported here https://bugzilla.gnome.org/show_bug.cgi?id=694197
WebKit Review Bot
Comment 5 2013-02-19 12:11:53 PST
Comment on attachment 189114 [details] Patch Clearing flags on attachment: 189114 Committed r143369: <http://trac.webkit.org/changeset/143369>
WebKit Review Bot
Comment 6 2013-02-19 12:11:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.