Bug 109824

Summary: [CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Layout and RenderingAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, noam
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110596    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Balazs Kelemen
Reported 2013-02-14 06:22:47 PST
Those #ifdefs are quite ugly, also bad for IDE's. Let's use a typedef.
Attachments
Patch (3.23 KB, patch)
2013-02-14 06:25 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (5.50 KB, patch)
2013-02-14 08:24 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2013-02-14 06:25:46 PST
Created attachment 188335 [details] Patch
Noam Rosenthal
Comment 2 2013-02-14 07:47:26 PST
Comment on attachment 188335 [details] Patch Can't we use the existing PaltformGraphicsContext typedef in GraphicsContext.h?
Balazs Kelemen
Comment 3 2013-02-14 08:24:42 PST
Created attachment 188359 [details] Patch
Noam Rosenthal
Comment 4 2013-02-14 08:27:46 PST
Comment on attachment 188359 [details] Patch I'm ok with this; Please get a WK2 signoff.
Balazs Kelemen
Comment 5 2013-02-22 04:43:30 PST
Could you approve Kling, it's just a style nit :)
Note You need to log in before you can comment on or make changes to this bug.