| Summary: | Stop placing std::isfinite and std::signbit inside the global scope | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, allan.jensen, andersca, ap, benjamin, cmarcelo, darin, d-r, eric.carlson, eric, feature-media-reviews, fmalita, gustavo, haraken, japhet, junov, macpherson, menard, mifenton, mrobinson, ojan.autocc, pdr, pnormand, schenney, senorblanco, tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2013-02-14 05:14:00 PST
Created attachment 188328 [details]
Patch
Comment on attachment 188328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188328&action=review > Source/WTF/ChangeLog:12 > + On Solaris and OpenBSD platforms or when using Visual C++ the two methods > + are now defined (as incompatibility workarounds) inside the std namespace. So this is a compile fix for Solaris and OpenBSD? When did Solaris/OpenBSD break? or have they always been broken? The basic approach on this in WebKit for years has been to work around these kinds of issues in the MathExtras.h header. Please put something in that header instead of changing every single call site for isfinite and signbit. Unless you want to change our strategy, which probably requires some webkit-dev conversation. Mu understanding is that we agreed to qualify names with std:: in this e-mail thread: <https://lists.webkit.org/pipermail/webkit-dev/2012-May/020656.html>. So this seems like the right thing to do. Is everyone now OK with that consensus and the proposed changes or would anyone like to repeat the discussion? Committed r143232: <http://trac.webkit.org/changeset/143232> |