Bug 109813

Summary: Web Inspector: always show memory size in Mb on the native memory graph
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Screenshot with the patch applied none

Yury Semikhatsky
Reported 2013-02-14 04:42:24 PST
The memory is displayed in bytes/Kb/Mb at the moment which makes it harder to compare counter values. Also such precision doesn't make much sense for the end users.
Attachments
Patch (1.67 KB, patch)
2013-02-14 04:43 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Screenshot with the patch applied (121.60 KB, image/png)
2013-02-14 04:43 PST, Yury Semikhatsky 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-02-14 04:43:23 PST
Created attachment 188320 [details] Patch
Yury Semikhatsky
Comment 2 2013-02-14 04:43:49 PST
Created attachment 188322 [details] Screenshot with the patch applied
WebKit Review Bot
Comment 3 2013-02-14 09:53:37 PST
Comment on attachment 188320 [details] Patch Rejecting attachment 188320 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 188320, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13634 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 53>At revision 13634. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/16537689
WebKit Review Bot
Comment 4 2013-02-14 23:46:56 PST
Comment on attachment 188320 [details] Patch Clearing flags on attachment: 188320 Committed r142969: <http://trac.webkit.org/changeset/142969>
WebKit Review Bot
Comment 5 2013-02-14 23:46:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.