Bug 109763

Summary: Make WebKit2 Derived Sources work with SDK identifiers too
Product: WebKit Reporter: David Farler <dfarler>
Component: Tools / TestsAssignee: David Farler <dfarler>
Status: RESOLVED FIXED    
Severity: Minor CC: ddkilzer, mrowe, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch none

Description David Farler 2013-02-13 16:00:52 PST 
Similar to https://bugs.webkit.org/show_bug.cgi?id=109324,

Source/WebCore/DerivedSources.make invokes CC with -isysroot $(SDKROOT), which won't work if you use an SDK identifier instead of an absolute path in Xcode. Where necessary, we should use pass SDKROOT=${SDKROOT} to make as we did in WebCore. This will let us use SDK identifiers when building with the makefiles.
Comment 1 David Farler 2013-02-13 16:06:09 PST 
Source/WebKit2 I should say.
Comment 2 David Farler 2013-02-13 16:29:17 PST 
Created attachment 188217 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2013-02-13 17:04:52 PST 
Comment on attachment 188217 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2013-02-13 17:32:41 PST 
Comment on attachment 188217 [details]
Patch

Clearing flags on attachment: 188217

Committed r142830: <http://trac.webkit.org/changeset/142830>
Comment 5 WebKit Review Bot 2013-02-13 17:32:44 PST 
All reviewed patches have been landed.  Closing bug.