Bug 109762

Summary: IndexedDB: Add a few more histogram calls
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

David Grogan
Reported 2013-02-13 16:00:03 PST
IndexedDB: Add a few more uma logging calls
Attachments
Patch (2.13 KB, patch)
2013-02-13 16:00 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (2.13 KB, patch)
2013-02-13 16:13 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (2.13 KB, patch)
2013-02-13 17:42 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2013-02-13 16:00:41 PST
Created attachment 188208 [details] Patch
David Grogan
Comment 2 2013-02-13 16:01:32 PST
Josh, could you prereview this?
WebKit Review Bot
Comment 3 2013-02-13 16:12:06 PST
Attachment 188208 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp']" exit_code: 1 Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Grogan
Comment 4 2013-02-13 16:13:15 PST
Created attachment 188209 [details] Patch
Joshua Bell
Comment 5 2013-02-13 16:58:43 PST
Comment on attachment 188209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188209&action=review lgtm > Source/WebCore/ChangeLog:3 > + IndexedDB: Add a few more uma logging calls Nit: UMA is Google/Chromium-specific terminology, Histogram is the generic WebKit API being used, so I'd refer to it that way. > Source/WebCore/ChangeLog:8 > + A few places where commits could fail weren't being logged. Whoah, how'd we miss these? :(
David Grogan
Comment 6 2013-02-13 17:42:54 PST
Created attachment 188235 [details] Patch
David Grogan
Comment 7 2013-02-13 17:43:46 PST
Tony, could you review this?
WebKit Review Bot
Comment 8 2013-02-14 10:19:34 PST
Comment on attachment 188235 [details] Patch Clearing flags on attachment: 188235 Committed r142890: <http://trac.webkit.org/changeset/142890>
WebKit Review Bot
Comment 9 2013-02-14 10:19:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.