| Summary: | IndexedDB: Add a few more histogram calls | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Grogan <dgrogan> | ||||||||
| Component: | New Bugs | Assignee: | David Grogan <dgrogan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alecflett, jsbell, tony, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
David Grogan
2013-02-13 16:00:03 PST
Created attachment 188208 [details]
Patch
Josh, could you prereview this? Attachment 188208 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp']" exit_code: 1
Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 188209 [details]
Patch
Comment on attachment 188209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188209&action=review lgtm > Source/WebCore/ChangeLog:3 > + IndexedDB: Add a few more uma logging calls Nit: UMA is Google/Chromium-specific terminology, Histogram is the generic WebKit API being used, so I'd refer to it that way. > Source/WebCore/ChangeLog:8 > + A few places where commits could fail weren't being logged. Whoah, how'd we miss these? :( Created attachment 188235 [details]
Patch
Tony, could you review this? Comment on attachment 188235 [details] Patch Clearing flags on attachment: 188235 Committed r142890: <http://trac.webkit.org/changeset/142890> All reviewed patches have been landed. Closing bug. |