Bug 109757

Summary: Merge MainResourceLoader::willSendRequest into DocumentLoader
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112542    
Bug Blocks: 104969    
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
Move checkNavigationPolicy to DocumentLoader too
buildbot: commit-queue-
Merged to trunk
buildbot: commit-queue-
Merged to trunk again
buildbot: commit-queue-
Try again to fix win-ews
none
Patch for landing none

Description Nate Chapin 2013-02-13 15:38:07 PST
* Move willSendRequest() to DocumentLoader, except calling checkNavigationPolicy for redirects.
* Move isPostOrRedirectAfterPost(), which is only called from willSendRequest()
* Get rid of MainResourceLoader::m_substituteData, which doesn't appear to need to be separate from DocumentLoader::m_substituteData
Comment 1 Nate Chapin 2013-02-13 15:51:14 PST
Created attachment 188204 [details]
patch
Comment 2 WebKit Review Bot 2013-02-13 17:38:39 PST
Comment on attachment 188204 [details]
patch

Attachment 188204 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16536367

New failing tests:
http/tests/security/referrer-policy-always.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html
platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html
Comment 3 Nate Chapin 2013-02-14 13:52:07 PST
Created attachment 188418 [details]
Move checkNavigationPolicy to DocumentLoader too
Comment 4 Build Bot 2013-02-16 10:21:09 PST
Comment on attachment 188418 [details]
Move checkNavigationPolicy to DocumentLoader too

Attachment 188418 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16587651
Comment 5 Nate Chapin 2013-03-12 10:23:41 PDT
Created attachment 192759 [details]
Merged to trunk
Comment 6 Build Bot 2013-03-13 02:39:18 PDT
Comment on attachment 192759 [details]
Merged to trunk

Attachment 192759 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17036740
Comment 7 Nate Chapin 2013-03-13 15:15:21 PDT
Created attachment 193005 [details]
Merged to trunk again
Comment 8 Build Bot 2013-03-13 16:12:19 PDT
Comment on attachment 193005 [details]
Merged to trunk again

Attachment 193005 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17207147
Comment 9 Adam Barth 2013-03-15 11:51:28 PDT
Comment on attachment 193005 [details]
Merged to trunk again

Is this patch still current?  Would you like me to look at it now, or should we resolve the win-ews redness first?
Comment 10 Nate Chapin 2013-03-15 11:52:52 PDT
(In reply to comment #9)
> (From update of attachment 193005 [details])
> Is this patch still current?  Would you like me to look at it now, or should we resolve the win-ews redness first?

It's current, but I haven't figured out why win-ews is red because an undefined HTMLFormElement while the other platforms compile.
Comment 11 Nate Chapin 2013-03-15 12:37:28 PDT
Created attachment 193355 [details]
Try again to fix win-ews
Comment 12 Antti Koivisto 2013-03-15 14:01:16 PDT
Comment on attachment 193355 [details]
Try again to fix win-ews

View in context: https://bugs.webkit.org/attachment.cgi?id=193355&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Merge MainResourceLoader::willSendRequest into DocumentLoader 
> +        https://bugs.webkit.org/show_bug.cgi?id=109757
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests, refactor only.

A few words of motivation would be nice.
Comment 13 Nate Chapin 2013-03-15 14:08:36 PDT
Created attachment 193372 [details]
Patch for landing
Comment 14 WebKit Review Bot 2013-03-15 18:23:01 PDT
Comment on attachment 193372 [details]
Patch for landing

Clearing flags on attachment: 193372

Committed r145973: <http://trac.webkit.org/changeset/145973>
Comment 15 WebKit Review Bot 2013-03-15 18:23:05 PDT
All reviewed patches have been landed.  Closing bug.