Bug 109756

Summary: Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Severity: Normal CC: cmarcelo, d-r, fmalita, kling, mifenton, ojan.autocc, pdr, schenney, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109505    
Description Flags
Patch koivisto: review+

Description Andreas Kling 2013-02-13 15:16:19 PST
It's a bit goofy to have an Element::getAttributeItem() that converts m_elementData to UniqueElementData.
This happens unintentionally in a few places where callers simply want to read an attribute value but are calling through an Element*.
Comment 1 Andreas Kling 2013-02-13 15:18:24 PST
Created attachment 188195 [details]
Comment 2 Antti Koivisto 2013-02-13 16:24:21 PST
Comment on attachment 188195 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=188195&action=review

> Source/WebCore/dom/Element.h:287
>      const Attribute* getAttributeItem(const QualifiedName&) const;

Some day these should get WebKit style names.
Comment 3 Andreas Kling 2013-02-13 17:14:10 PST
Committed r142827: <http://trac.webkit.org/changeset/142827>