Summary: | CSSPreloadScanner should not depend on HTMLToken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, ojan.autocc, tonyg, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106127 | ||||||
Attachments: |
|
Description
Adam Barth
2013-02-13 13:21:47 PST
Created attachment 188162 [details]
Patch
Comment on attachment 188162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review > Source/WebCore/html/parser/CSSPreloadScanner.cpp:61 > +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >& requests) This is just a template. :) > Source/WebCore/html/parser/CSSPreloadScanner.h:44 > + void scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >&); This isn't currently used, or? (In reply to comment #2) > (From update of attachment 188162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review > > > Source/WebCore/html/parser/CSSPreloadScanner.cpp:61 > > +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >& requests) > > This is just a template. :) Yes. ;) > > Source/WebCore/html/parser/CSSPreloadScanner.h:44 > > + void scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >&); > > This isn't currently used, or? Current unused. I can add it later when we need it if you like. Comment on attachment 188162 [details] Patch Clearing flags on attachment: 188162 Committed r142803: <http://trac.webkit.org/changeset/142803> All reviewed patches have been landed. Closing bug. |