Summary: | Remove unnecessary indirection to non-local variable access operations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, jbriance, roger_fong | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Oliver Hunt
2013-02-13 11:52:05 PST
Created attachment 188139 [details]
Patch
Committed r142769: <http://trac.webkit.org/changeset/142769> Hello, this broke the Windows build: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44150/steps/compile-webkit/logs/stdio This breaks our SH4 build slave too: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/20014 I took a look very quickly and I wonder if some parts of this patch should be conditionnal to DFG_JIT. (In reply to comment #3) > Hello, this broke the Windows build: > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44150/steps/compile-webkit/logs/stdio Still broken but for a different reason: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44173/steps/compile-webkit/logs/stdio profile was placed in the DFG_JIT enable so it's no longer declared. I could move that line into the ifdef but I'd rather not risk touching this stuff. Can I roll this out? Or is someone working on a fix? (In reply to comment #6) > Can I roll this out? Or is someone working on a fix? I landed a fix Ah yup, Windows is broken on something else now. Thanks for the fix! (In reply to comment #7) > (In reply to comment #6) > > Can I roll this out? Or is someone working on a fix? > > I landed a fix Thanks for the fix! |