Bug 109706

Summary: [chromium] move mock notification presenter to TestRunner library
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91308    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

jochen
Reported 2013-02-13 09:11:48 PST
[chromium] move mock notification presenter to TestRunner library
Attachments
Patch (36.32 KB, patch)
2013-02-13 09:13 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (38.36 KB, patch)
2013-02-13 10:20 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (38.38 KB, patch)
2013-02-13 11:41 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-02-13 09:13:37 PST
Created attachment 188095 [details] Patch
WebKit Review Bot
Comment 2 2013-02-13 09:17:11 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Peter Beverloo (cr-android ews)
Comment 3 2013-02-13 09:23:58 PST
Comment on attachment 188095 [details] Patch Attachment 188095 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16487964
jochen
Comment 4 2013-02-13 10:20:48 PST
Created attachment 188115 [details] Patch
Adam Barth
Comment 5 2013-02-13 11:33:03 PST
Comment on attachment 188115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188115&action=review > Tools/DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h:44 > +// A class that implements WebNotificationPresenter for DRT. DRT <--- I'd probably change this comment slightly.
jochen
Comment 6 2013-02-13 11:41:02 PST
Created attachment 188132 [details] Patch for landing
WebKit Review Bot
Comment 7 2013-02-14 00:09:20 PST
Comment on attachment 188132 [details] Patch for landing Clearing flags on attachment: 188132 Committed r142857: <http://trac.webkit.org/changeset/142857>
WebKit Review Bot
Comment 8 2013-02-14 00:09:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.