Bug 109697

Summary: Web Inspector: Color picker should not be available in Computed Styles pane
Product: WebKit Reporter: Vladislav Kaznacheev <kaznacheev>
Component: Web Inspector (Deprecated)Assignee: Vladislav Kaznacheev <kaznacheev>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 109920    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Vladislav Kaznacheev 2013-02-13 08:02:21 PST 
Currently clicking on a color square in the Computed Style pane opens a Color Picker which does not add any useful functionality (changes are ignored and closing the picker causes a Javascript exception in the console).
Comment 1 Vladislav Kaznacheev 2013-02-13 08:38:57 PST 
Created attachment 188088 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-14 07:16:57 PST 
Comment on attachment 188088 [details]
Patch

Clearing flags on attachment: 188088

Committed r142876: <http://trac.webkit.org/changeset/142876>
Comment 3 WebKit Review Bot 2013-02-14 07:17:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2013-02-15 03:38:12 PST 
Re-opened since this is blocked by bug 109920
Comment 5 Vladislav Kaznacheev 2013-02-18 02:07:36 PST 
Created attachment 188828 [details]
Patch
Comment 6 Pavel Feldman 2013-02-18 04:31:45 PST 
Comment on attachment 188828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188828&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1572
> +     * @return {WebInspector.DOMNode}

{?WebInspector.DOMNode}

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1580
> +     * @return {WebInspector.StylesSidebarPane}

return ?WebInspector.StylesSidebarPane

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1940
> +

Too much whitespace
Comment 7 Vladislav Kaznacheev 2013-02-18 04:41:04 PST 
Comment on attachment 188828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188828&action=review

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1572
>> +     * @return {WebInspector.DOMNode}
> 
> {?WebInspector.DOMNode}

Done

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1580
>> +     * @return {WebInspector.StylesSidebarPane}
> 
> return ?WebInspector.StylesSidebarPane

Done

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1940
>> +
> 
> Too much whitespace

Done
Comment 8 Vladislav Kaznacheev 2013-02-18 04:42:38 PST 
Created attachment 188850 [details]
Patch
Comment 9 WebKit Review Bot 2013-02-18 06:03:35 PST 
Comment on attachment 188850 [details]
Patch

Clearing flags on attachment: 188850

Committed r143207: <http://trac.webkit.org/changeset/143207>
Comment 10 WebKit Review Bot 2013-02-18 06:03:39 PST 
All reviewed patches have been landed.  Closing bug.