Bug 109689

Summary: replaceWithJump should not decrease the offset by 1 on ARM traditional.
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, laszlo.gombos, oliver, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
patch oliver: review+

Zoltan Herczeg
Reported 2013-02-13 06:49:27 PST
It is sad we did not find it before.
Attachments
patch (1.31 KB, patch)
2013-02-13 06:52 PST, Zoltan Herczeg 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Herczeg
Comment 1 2013-02-13 06:52:42 PST
Created attachment 188076 [details] patch
WebKit Review Bot
Comment 2 2013-02-13 08:25:08 PST
Comment on attachment 188076 [details] patch Clearing flags on attachment: 188076 Committed r142751: <http://trac.webkit.org/changeset/142751>
WebKit Review Bot
Comment 3 2013-02-13 08:25:11 PST
All reviewed patches have been landed. Closing bug.
Zoltan Herczeg
Comment 4 2013-02-14 02:10:49 PST
Hm... why this patch is landed... Uh it seems I hit the wrong buttons when I submitted the patch and reviewed myself... Sorry. Could someone else check the patch?
Oliver Hunt
Comment 5 2013-02-14 08:53:50 PST
Comment on attachment 188076 [details] patch Looks sane to me :D
Zoltan Herczeg
Comment 6 2013-02-15 01:03:41 PST
(In reply to comment #5) > (From update of attachment 188076 [details]) > Looks sane to me :D Thanks! Changelog fixed in r142970.
Note You need to log in before you can comment on or make changes to this bug.