Bug 109689

Summary: replaceWithJump should not decrease the offset by 1 on ARM traditional.
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: fpizlo, laszlo.gombos, oliver, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Description Flags
patch oliver: review+

Description Zoltan Herczeg 2013-02-13 06:49:27 PST
It is sad we did not find it before.
Comment 1 Zoltan Herczeg 2013-02-13 06:52:42 PST
Created attachment 188076 [details]
Comment 2 WebKit Review Bot 2013-02-13 08:25:08 PST
Comment on attachment 188076 [details]

Clearing flags on attachment: 188076

Committed r142751: <http://trac.webkit.org/changeset/142751>
Comment 3 WebKit Review Bot 2013-02-13 08:25:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Zoltan Herczeg 2013-02-14 02:10:49 PST
Hm... why this patch is landed... Uh it seems I hit the wrong buttons when I submitted the patch and reviewed myself... Sorry. Could someone else check the patch?
Comment 5 Oliver Hunt 2013-02-14 08:53:50 PST
Comment on attachment 188076 [details]

Looks sane to me :D
Comment 6 Zoltan Herczeg 2013-02-15 01:03:41 PST
(In reply to comment #5)
> (From update of attachment 188076 [details])
> Looks sane to me :D

Thanks! Changelog fixed in r142970.