| Summary: | Column rules not affected by scroll offset | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Morten Stenshorne <mstensho> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, eric, esprehn+autocc, glenn, hyatt, kondapallykalyan, ojan.autocc, shezbaig.wk, simon.fraser, thorton, webkit.review.bot | ||||||||||||
| Priority: | P3 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 188570 [details]
Corrected testcase
Created attachment 190464 [details]
Patch
Comment on attachment 190464 [details]
Patch
I'm sorry we didn't review this sooner. It seems like a good change, but now needs to be adjusted a bit to apply cleanly (since a year has past!) Would you be willing to rebaseline the patch so we could push it through?
Sure! Created attachment 230090 [details]
Patch
Ooh... Hyatt not CCed. Now he is. :) Fixing the old multicol implementation at this point is rather unimportant, of course, but I thought at least the test would be nice to have. This actually fails with the new multicolumn code now that I changed rule painting! Good catch! Let me make a patch for the new code (the old code doesn't matter). Note column rules don't respect overflow:hidden clips in either old or new versions. We will need a bug on that too, and it's a bit harder to fix. :( Created attachment 230196 [details]
Patch
Fixed in r167820. |
Created attachment 188060 [details] Testcase If a multicol container has scrollable overflow, the column rules are not scrolled along with the content; instead they remain "fixed".