Bug 109667

Summary: [V8] There is no XXXConstructor that requires a custom getter
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2013-02-12 23:37:02 PST
Currently '[Custom] attribute XXXConstructor xxx' generates XXXAttrGetter(). However, there is no XXXConstructor with [Custom]. In addition, it does make no sense to generate XXXAttrGetter() for such cases. We can remove the logic from CodeGeneratorV8.pm.
Attachments
Patch (2.15 KB, patch)
2013-02-12 23:38 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-12 23:38:22 PST
Created attachment 188021 [details] Patch
WebKit Review Bot
Comment 2 2013-02-13 00:11:41 PST
Comment on attachment 188021 [details] Patch Clearing flags on attachment: 188021 Committed r142727: <http://trac.webkit.org/changeset/142727>
WebKit Review Bot
Comment 3 2013-02-13 00:11:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.