Bug 109653

Summary: [Refactoring] Make SelectorChecker::mode a constructor parameter.
Product: WebKit Reporter: Takashi Sakamoto <tasak>
Component: CSSAssignee: Takashi Sakamoto <tasak>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
Patch none

Description Takashi Sakamoto 2013-02-12 20:32:01 PST 
Since StyleResolver uses SelectorChecker as an on-stack object now, no need to use setMode(Mode) to change SelectorChecker's mode.
Instead, we can make the mode a constructor parameter.
Comment 1 Takashi Sakamoto 2013-02-12 20:35:37 PST 
Created attachment 187997 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2013-02-12 20:42:34 PST 
Comment on attachment 187997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187997&action=review

> Source/WebCore/css/SelectorChecker.cpp:65
> +SelectorChecker::SelectorChecker(Document* document, Mode mode)

Does Mode declaration need to move to StyleResolver now?
Comment 3 WebKit Review Bot 2013-02-12 21:11:50 PST 
Comment on attachment 187997 [details]
Patch

Clearing flags on attachment: 187997

Committed r142717: <http://trac.webkit.org/changeset/142717>
Comment 4 WebKit Review Bot 2013-02-12 21:11:54 PST 
All reviewed patches have been landed.  Closing bug.