Bug 109652

Summary: Unnecessary and confusing includes in StreamBuffer.h
Product: WebKit Reporter: Takeshi Yoshino <tyoshino>
Component: Web Template FrameworkAssignee: Takeshi Yoshino <tyoshino>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, ojan.autocc, toyoshim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Takeshi Yoshino
Reported 2013-02-12 19:57:59 PST
StreamBuffer.h is using OwnPtr for storing Vectors into a Deque. FixedArray.h and PassOwnPtr.h are included but not used. VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy. So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > > is even slower).
Attachments
Patch (1.29 KB, patch)
2013-02-12 20:10 PST, Takeshi Yoshino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takeshi Yoshino
Comment 1 2013-02-12 20:10:52 PST
Created attachment 187995 [details] Patch
WebKit Review Bot
Comment 2 2013-02-12 21:18:56 PST
Comment on attachment 187995 [details] Patch Clearing flags on attachment: 187995 Committed r142718: <http://trac.webkit.org/changeset/142718>
WebKit Review Bot
Comment 3 2013-02-12 21:18:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.