Bug 109652 - Unnecessary and confusing includes in StreamBuffer.h
Summary: Unnecessary and confusing includes in StreamBuffer.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Takeshi Yoshino
Depends on:
Reported: 2013-02-12 19:57 PST by Takeshi Yoshino
Modified: 2013-02-12 21:18 PST (History)
5 users (show)

See Also:

Patch (1.29 KB, patch)
2013-02-12 20:10 PST, Takeshi Yoshino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takeshi Yoshino 2013-02-12 19:57:59 PST
StreamBuffer.h is using OwnPtr for storing Vectors into a Deque. FixedArray.h and PassOwnPtr.h are included but not used.

VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy. So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > > is even slower).
Comment 1 Takeshi Yoshino 2013-02-12 20:10:52 PST
Created attachment 187995 [details]
Comment 2 WebKit Review Bot 2013-02-12 21:18:56 PST
Comment on attachment 187995 [details]

Clearing flags on attachment: 187995

Committed r142718: <http://trac.webkit.org/changeset/142718>
Comment 3 WebKit Review Bot 2013-02-12 21:18:59 PST
All reviewed patches have been landed.  Closing bug.