| Summary: | Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||||
| Component: | UI Events | Assignee: | Hayato Ito <hayato> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ojan.autocc, webcomponents-bugzilla, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 109561 | ||||||||||
| Bug Blocks: | 109156 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 187996 [details]
Use FocusEvent.relatedTarget.
The uploaded patch depends on the patch in bug 109561. Created attachment 188000 [details]
Rabased
Comment on attachment 188000 [details] Rabased View in context: https://bugs.webkit.org/attachment.cgi?id=188000&action=review > Source/WebCore/dom/FocusEvent.h:101 > + FocusInEventDispatchMediator(PassRefPtr<FocusEvent>); explicit? > Source/WebCore/dom/FocusEvent.h:110 > + FocusOutEventDispatchMediator(PassRefPtr<FocusEvent>); explicit? Thank you for the review. Let me land this after making these single parameter constructors explicit. (In reply to comment #4) > (From update of attachment 188000 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188000&action=review > > > Source/WebCore/dom/FocusEvent.h:101 > > + FocusInEventDispatchMediator(PassRefPtr<FocusEvent>); > > explicit? > > > Source/WebCore/dom/FocusEvent.h:110 > > + FocusOutEventDispatchMediator(PassRefPtr<FocusEvent>); > > explicit? Created attachment 188008 [details]
Patch for landing
Comment on attachment 188008 [details] Patch for landing Clearing flags on attachment: 188008 Committed r142719: <http://trac.webkit.org/changeset/142719> All reviewed patches have been landed. Closing bug. |
Remove m_{old,new}FocusedNode member variable from these mediators It's redundant since FocusEvent has relatedTarget member variable.