Bug 109648

Summary:

Clicking outside captions menu should dismiss it

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, feature-media-reviews, gyuyoung.kim, ojan.autocc, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Dean Jackson 2013-02-12 18:47:27 PST

Clicking outside captions menu should dismiss it

Comment 1 Dean Jackson 2013-02-12 18:51:37 PST

Created attachment 187992 [details]
Patch

Comment 2 Eric Carlson 2013-02-12 21:36:11 PST

Comment on attachment 187992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187992&action=review

> Source/WebCore/html/shadow/MediaControlsApple.cpp:283
> +    if (event->type() == eventNames().clickEvent) {
> +        if (m_closedCaptionsContainer && m_closedCaptionsContainer->isShowing())
> +            m_closedCaptionsContainer->hide();

You should stop the event propagation so it doesn't get any further, and eg. pause playback in a media document.

Comment 3 Dean Jackson 2013-02-13 12:37:47 PST

Committed r142774: <http://trac.webkit.org/changeset/142774>