Bug 109648

Summary: Clicking outside captions menu should dismiss it
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gyuyoung.kim, ojan.autocc, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Dean Jackson
Reported 2013-02-12 18:47:27 PST
Clicking outside captions menu should dismiss it
Attachments
Patch (11.26 KB, patch)
2013-02-12 18:51 PST, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-02-12 18:51:37 PST
Created attachment 187992 [details] Patch
Eric Carlson
Comment 2 2013-02-12 21:36:11 PST
Comment on attachment 187992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187992&action=review > Source/WebCore/html/shadow/MediaControlsApple.cpp:283 > + if (event->type() == eventNames().clickEvent) { > + if (m_closedCaptionsContainer && m_closedCaptionsContainer->isShowing()) > + m_closedCaptionsContainer->hide(); You should stop the event propagation so it doesn't get any further, and eg. pause playback in a media document.
Dean Jackson
Comment 3 2013-02-13 12:37:47 PST
Committed r142774: <http://trac.webkit.org/changeset/142774>
Note You need to log in before you can comment on or make changes to this bug.