Bug 109642

Summary: [Internals] setShadowDOMEnabled() shouldn't be used except a few tests
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Hajime Morrita
Reported 2013-02-12 17:57:31 PST
https://code.google.com/p/chromium/issues/detail?id=174033 The misuse of the flag can cause an assertion failure.
Attachments
Patch (4.64 KB, patch)
2013-02-12 18:49 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.67 KB, patch)
2013-02-12 23:16 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2013-02-12 18:49:12 PST
Created attachment 187991 [details] Patch
Kent Tamura
Comment 2 2013-02-12 23:09:05 PST
Comment on attachment 187991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187991&action=review Looks ugly hack. But I also have no other ideas. > Source/WebCore/ChangeLog:8 > + InternalSettings.setShadowDOMEnabled() shouldn't be alled after alled -> called? > Source/WebCore/testing/InternalSettings.cpp:198 > +static bool urlIsWhitelisted(const String& url) The function name is too generic. urlIsInWhitelistForSetShadowDOMEnabled?
Hajime Morrita
Comment 3 2013-02-12 23:16:42 PST
Comment on attachment 187991 [details] Patch Thanks for taking a look! I'm addressing the point and landing.
Hajime Morrita
Comment 4 2013-02-12 23:16:55 PST
Created attachment 188018 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-02-12 23:36:26 PST
Comment on attachment 188018 [details] Patch for landing Clearing flags on attachment: 188018 Committed r142726: <http://trac.webkit.org/changeset/142726>
WebKit Review Bot
Comment 6 2013-02-12 23:36:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.