Bug 109642

Summary: [Internals] setShadowDOMEnabled() shouldn't be used except a few tests
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Hajime Morrita 2013-02-12 17:57:31 PST 
https://code.google.com/p/chromium/issues/detail?id=174033
The misuse of the flag can cause an assertion failure.
Comment 1 Hajime Morrita 2013-02-12 18:49:12 PST 
Created attachment 187991 [details]
Patch
Comment 2 Kent Tamura 2013-02-12 23:09:05 PST 
Comment on attachment 187991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187991&action=review

Looks ugly hack. But I also have no other ideas.

> Source/WebCore/ChangeLog:8
> +        InternalSettings.setShadowDOMEnabled() shouldn't be alled after

alled -> called?

> Source/WebCore/testing/InternalSettings.cpp:198
> +static bool urlIsWhitelisted(const String& url)

The function name is too generic.  urlIsInWhitelistForSetShadowDOMEnabled?
Comment 3 Hajime Morrita 2013-02-12 23:16:42 PST 
Comment on attachment 187991 [details]
Patch

Thanks for taking a look! I'm addressing the point and landing.
Comment 4 Hajime Morrita 2013-02-12 23:16:55 PST 
Created attachment 188018 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-02-12 23:36:26 PST 
Comment on attachment 188018 [details]
Patch for landing

Clearing flags on attachment: 188018

Committed r142726: <http://trac.webkit.org/changeset/142726>
Comment 6 WebKit Review Bot 2013-02-12 23:36:29 PST 
All reviewed patches have been landed.  Closing bug.