Bug 109629

Summary: [Windows] Revise WebKit Project to Show Generated Export Definition Files
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch mrowe: review+

Brent Fulgham
Reported 2013-02-12 16:37:22 PST
I recently wasted a bit of time trying to track down a linker error, only to later realize that the problem was that the JavaScriptCoreExportGenerator project had emitted an empty JavaScriptCoreExports.def file. Since these files are now autogenerated, I think it would be nice if they appeared in the relevant project files as "Generated" sources that could be easily inspected from within Visual Studio. The attached patch adds these two files, so they can be quickly checked to confirm proper generator function.
Attachments
Patch (4.97 KB, patch)
2013-02-12 16:56 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.72 KB, patch)
2013-06-13 09:24 PDT, Brent Fulgham 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-02-12 16:56:12 PST
Created attachment 187962 [details] Patch
Brent Fulgham
Comment 2 2013-06-13 09:24:25 PDT
Created attachment 204622 [details] Patch
Brent Fulgham
Comment 3 2013-06-13 10:03:58 PDT
Committed r151557: <http://trac.webkit.org/changeset/151557>
Note You need to log in before you can comment on or make changes to this bug.