Bug 109610

Summary: Move ElementAttributeData into Element.cpp/h
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, gyuyoung.kim, kling, ojan.autocc, peter+ews, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109505    
Attachments:
Description Flags
Patch
andersca: review+, webkit.review.bot: commit-queue-
Patch for landing
kling: commit-queue+
Patch for landing none

Description Andreas Kling 2013-02-12 13:40:52 PST
ElementAttributeData is really just a slightly-less-than-dumb container that holds data for Element.
I envision a future where Element is the only client of this class. As a first step, let's move the class into Element.h/cpp.
Comment 1 Andreas Kling 2013-02-12 13:46:19 PST
Created attachment 187925 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-12 14:29:44 PST
Comment on attachment 187925 [details]
Patch

Attachment 187925 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16513403
Comment 3 WebKit Review Bot 2013-02-12 14:50:06 PST
Comment on attachment 187925 [details]
Patch

Attachment 187925 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16444492
Comment 4 Peter Beverloo (cr-android ews) 2013-02-12 15:10:56 PST
Comment on attachment 187925 [details]
Patch

Attachment 187925 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16440447
Comment 5 Andreas Kling 2013-02-12 15:53:50 PST
Created attachment 187953 [details]
Patch for landing
Comment 6 Andreas Kling 2013-02-12 16:18:34 PST
Created attachment 187958 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-02-12 17:45:33 PST
Comment on attachment 187958 [details]
Patch for landing

Clearing flags on attachment: 187958

Committed r142698: <http://trac.webkit.org/changeset/142698>
Comment 8 WebKit Review Bot 2013-02-12 17:45:38 PST
All reviewed patches have been landed.  Closing bug.