Bug 109549 – Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller

[Ryosuke Niwa]

Created attachment 187785 [details]
Cleanup

[EFL EWS Bot]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16521010

[Early Warning System Bot]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16454065

[Early Warning System Bot]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16521009

[kov's GTK+ EWS bot]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16520008

[WebKit Review Bot]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16439063

[WebKit Review Bot]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16515011

[Peter Beverloo (cr-android ews)]

Comment on attachment 187785 [details]
Cleanup

Attachment 187785 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16520006

[Ryosuke Niwa]

Created attachment 187792 [details]
Patch

[Early Warning System Bot]

Comment on attachment 187792 [details]
Patch

Attachment 187792 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16444087

[Early Warning System Bot]

Comment on attachment 187792 [details]
Patch

Attachment 187792 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16519022

[EFL EWS Bot]

Comment on attachment 187792 [details]
Patch

Attachment 187792 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16444090

[Ryosuke Niwa]

Created attachment 187798 [details]
Fixed build

[Tony Chang]

Comment on attachment 187798 [details]
Fixed build

View in context: https://bugs.webkit.org/attachment.cgi?id=187798&action=review

> Source/WebCore/editing/Editor.h:105
> +    PassRefPtr<Range> avoidIntersectionWithDeleteButtonController(const Range* range) const { return range ? range->cloneRange(ASSERT_NO_EXCEPTION) : 0; }

Maybe mention why we need to clone the range in the ChangeLog?

> Source/WebCore/editing/markup.cpp:642
> +    // Disable the delete button so it's elements are not serialized into the markup,

Nit: it's -> its

[Ryosuke Niwa]

Comment on attachment 187798 [details]
Fixed build

View in context: https://bugs.webkit.org/attachment.cgi?id=187798&action=review

Thanks for the review!

>> Source/WebCore/editing/Editor.h:105
>> +    PassRefPtr<Range> avoidIntersectionWithDeleteButtonController(const Range* range) const { return range ? range->cloneRange(ASSERT_NO_EXCEPTION) : 0; }
> 
> Maybe mention why we need to clone the range in the ChangeLog?

The only reason I need it is because we take const Range* :( But this code is never used because the only caller is createMarkup and
the code is wrapped inside if-def ENABLE(DELETION_UI) so I'm gonna just delete this function for now.

[Ryosuke Niwa]

Committed r142705: <http://trac.webkit.org/changeset/142705>

[Ryosuke Niwa]

Apparently there was one more caller of Range* function :( Landed a crude fix in http://trac.webkit.org/changeset/142711.