Bug 109545

Summary: DFG CompareEq optimization should be retuned
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mhahnenberg: review+

Description Filip Pizlo 2013-02-11 22:00:03 PST
Couple of things seem to have gone wrong:

- Backend still emits checks even if the CFA has proven them to be unnecessary

- Object-to-object comparisons seem to no longer be emitted
Comment 1 Oliver Hunt 2013-02-11 22:06:35 PST
(In reply to comment #0)
> Couple of things seem to have gone wrong:
> 
> - Backend still emits checks even if the CFA has proven them to be unnecessary
> 
> - Object-to-object comparisons seem to no longer be emitted

inverted branch? :-D
Comment 2 Filip Pizlo 2013-02-11 22:07:33 PST
(In reply to comment #1)
> (In reply to comment #0)
> > Couple of things seem to have gone wrong:
> > 
> > - Backend still emits checks even if the CFA has proven them to be unnecessary
> > 
> > - Object-to-object comparisons seem to no longer be emitted
> 
> inverted branch? :-D

Affirmative.
Comment 3 Filip Pizlo 2013-02-11 23:17:03 PST
Created attachment 187779 [details]
the patch
Comment 4 Mark Hahnenberg 2013-02-12 08:56:45 PST
Comment on attachment 187779 [details]
the patch

r=me
Comment 5 Filip Pizlo 2013-02-12 09:35:54 PST
Landed in http://trac.webkit.org/changeset/142636