Bug 109545

Summary: DFG CompareEq optimization should be retuned
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2013-02-11 22:00:03 PST
Couple of things seem to have gone wrong: - Backend still emits checks even if the CFA has proven them to be unnecessary - Object-to-object comparisons seem to no longer be emitted
Attachments
the patch (36.91 KB, patch)
2013-02-11 23:17 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-02-11 22:06:35 PST
(In reply to comment #0) > Couple of things seem to have gone wrong: > > - Backend still emits checks even if the CFA has proven them to be unnecessary > > - Object-to-object comparisons seem to no longer be emitted inverted branch? :-D
Filip Pizlo
Comment 2 2013-02-11 22:07:33 PST
(In reply to comment #1) > (In reply to comment #0) > > Couple of things seem to have gone wrong: > > > > - Backend still emits checks even if the CFA has proven them to be unnecessary > > > > - Object-to-object comparisons seem to no longer be emitted > > inverted branch? :-D Affirmative.
Filip Pizlo
Comment 3 2013-02-11 23:17:03 PST
Created attachment 187779 [details] the patch
Mark Hahnenberg
Comment 4 2013-02-12 08:56:45 PST
Comment on attachment 187779 [details] the patch r=me
Filip Pizlo
Comment 5 2013-02-12 09:35:54 PST
Landed in http://trac.webkit.org/changeset/142636
Note You need to log in before you can comment on or make changes to this bug.