Bug 109542

Summary: JSObject for ChannelSplitterNode and ChannelMergerNode are not created
Product: WebKit Reporter: Praveen Jadhav <praveen.j>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cdumez, crogers, eric.carlson, feature-media-reviews, ggaren, haraken, ojan.autocc, sam, s.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Praveen Jadhav 2013-02-11 21:11:14 PST 
IDL files of ChannelSplitterNode and ChannelMergerNode in WebAudio don't include "JSGenerateToJSObject". As a result, Objects of base class AudioNode is created even if html expects ChannelSplitterNode and ChannelMergerNode respectively. We are not sure if this is intentional. Please clarify.
Comment 1 Praveen Jadhav 2013-02-13 20:45:27 PST 
Created attachment 188256 [details]
Patch

IDL file is updated to make sure JSObjects of ChannelSplitterNode and ChannelMergerNode are created.
Comment 2 Kentaro Hara 2013-02-13 20:46:35 PST 
Comment on attachment 188256 [details]
Patch

The change looks reasonable. Would you add a test for it?
Comment 3 Praveen Jadhav 2013-02-13 21:42:29 PST 
Created attachment 188259 [details]
Patch
Comment 4 Praveen Jadhav 2013-02-13 21:43:31 PST 
Created attachment 188260 [details]
Patch

Patch updated with LayoutTests.
Comment 5 Kentaro Hara 2013-02-13 21:45:06 PST 
Comment on attachment 188260 [details]
Patch

Looks good. Thanks.
Comment 6 WebKit Review Bot 2013-02-13 22:05:52 PST 
Comment on attachment 188260 [details]
Patch

Clearing flags on attachment: 188260

Committed r142848: <http://trac.webkit.org/changeset/142848>
Comment 7 WebKit Review Bot 2013-02-13 22:05:58 PST 
All reviewed patches have been landed.  Closing bug.