Bug 109542

Summary: JSObject for ChannelSplitterNode and ChannelMergerNode are not created
Product: WebKit Reporter: Praveen Jadhav <praveen.j>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cdumez, crogers, eric.carlson, feature-media-reviews, ggaren, haraken, ojan.autocc, sam, s.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Praveen Jadhav
Reported 2013-02-11 21:11:14 PST
IDL files of ChannelSplitterNode and ChannelMergerNode in WebAudio don't include "JSGenerateToJSObject". As a result, Objects of base class AudioNode is created even if html expects ChannelSplitterNode and ChannelMergerNode respectively. We are not sure if this is intentional. Please clarify.
Attachments
Patch (1.71 KB, patch)
2013-02-13 20:45 PST, Praveen Jadhav 		no flags
DetailsFormatted DiffDiff
Patch (5.46 KB, text/plain)
2013-02-13 21:42 PST, Praveen Jadhav 		no flags
Details
Patch (5.46 KB, patch)
2013-02-13 21:43 PST, Praveen Jadhav 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Praveen Jadhav
Comment 1 2013-02-13 20:45:27 PST
Created attachment 188256 [details] Patch IDL file is updated to make sure JSObjects of ChannelSplitterNode and ChannelMergerNode are created.
Kentaro Hara
Comment 2 2013-02-13 20:46:35 PST
Comment on attachment 188256 [details] Patch The change looks reasonable. Would you add a test for it?
Praveen Jadhav
Comment 3 2013-02-13 21:42:29 PST
Created attachment 188259 [details] Patch
Praveen Jadhav
Comment 4 2013-02-13 21:43:31 PST
Created attachment 188260 [details] Patch Patch updated with LayoutTests.
Kentaro Hara
Comment 5 2013-02-13 21:45:06 PST
Comment on attachment 188260 [details] Patch Looks good. Thanks.
WebKit Review Bot
Comment 6 2013-02-13 22:05:52 PST
Comment on attachment 188260 [details] Patch Clearing flags on attachment: 188260 Committed r142848: <http://trac.webkit.org/changeset/142848>
WebKit Review Bot
Comment 7 2013-02-13 22:05:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.