Bug 109534

Summary:

Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cmarcelo, ddkilzer, enrica, gyuyoung.kim, japhet, mifenton, mrobinson, ojan.autocc, rakuco, rniwa, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109517, 109557

Bug Blocks:

109549

Attachments:

Description	Flags
Disables the feature on non-Mac ports	andersca: review+, buildbot: commit-queue-

Description Ryosuke Niwa 2013-02-11 18:38:05 PST

Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface

Comment 1 Ryosuke Niwa 2013-02-11 18:38:42 PST

Created attachment 187748 [details]
Disables the feature on non-Mac ports

Comment 2 Martin Robinson 2013-02-11 19:20:25 PST

The GTK+ bits look good!

Comment 3 Build Bot 2013-02-11 20:13:13 PST

Comment on attachment 187748 [details]
Disables the feature on non-Mac ports

Attachment 187748 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16492584

Comment 4 Anders Carlsson 2013-02-11 20:33:27 PST

Comment on attachment 187748 [details]
Disables the feature on non-Mac ports

View in context: https://bugs.webkit.org/attachment.cgi?id=187748&action=review

> Source/WebCore/editing/DeleteButtonController.cpp:285
> +    EditorClient* clinet = m_frame->editor()->client();

clinet -> client.

Comment 5 Ryosuke Niwa 2013-02-11 20:57:04 PST

Committed r142576: <http://trac.webkit.org/changeset/142576>

Comment 6 David Kilzer (:ddkilzer) 2013-02-12 08:47:20 PST

(In reply to comment #5)
> Committed r142576: <http://trac.webkit.org/changeset/142576>

Follow-up build fix:

Committed r142629: < http://trac.webkit.org/changeset/142629>