Bug 109529

Summary: Better names for ElementAttributeData & subclasses.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, dglazkov, d-r, fmalita, kling, koivisto, macpherson, menard, mifenton, ojan.autocc, pdr, schenney, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109505    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch
webkit.review.bot: commit-queue-
Patch
none
Patch
none
Patch koivisto: review+

Andreas Kling
Reported 2013-02-11 17:48:49 PST
Here's what I'm thinking: ElementAttributeData => ElementData MutableElementAttributeData => PrivateElementAttributeData ImmutableElementAttributeDat a=> SharableElementAttributeData Element::attributeData() -> Element::elementData() Element::mutableAttributeData() => Element::ensurePrivateElementData()
Attachments
Patch (76.33 KB, patch)
2013-02-11 18:05 PST, Andreas Kling 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (77.01 KB, patch)
2013-02-11 19:11 PST, Andreas Kling 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (75.04 KB, patch)
2013-02-13 10:05 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (75.04 KB, patch)
2013-02-13 11:46 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (74.95 KB, patch)
2013-02-13 12:20 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-02-11 17:52:41 PST
MutableElementAttributeData => PrivateElementData ImmutableElementAttributeData => SharableElementData Is what I meant, duh.
Andreas Kling
Comment 2 2013-02-11 18:05:40 PST
Created attachment 187739 [details] Patch
WebKit Review Bot
Comment 3 2013-02-11 18:39:52 PST
Comment on attachment 187739 [details] Patch Attachment 187739 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16487609
Andreas Kling
Comment 4 2013-02-11 19:11:14 PST
Created attachment 187753 [details] Patch
WebKit Review Bot
Comment 5 2013-02-11 21:15:33 PST
Comment on attachment 187753 [details] Patch Attachment 187753 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16489683
Andreas Kling
Comment 6 2013-02-11 21:21:04 PST
Comment on attachment 187753 [details] Patch Actually, let's move stuff to Element.h/cpp first so we get as much version control history as possible.
Andreas Kling
Comment 7 2013-02-13 10:05:03 PST
Created attachment 188108 [details] Patch
Andreas Kling
Comment 8 2013-02-13 11:46:09 PST
Created attachment 188134 [details] Patch
Antti Koivisto
Comment 9 2013-02-13 11:51:20 PST
Comment on attachment 188134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188134&action=review > Source/WebCore/ChangeLog:17 > + - MutableElementAttributeData => PrivateElementData "Private" is bit overloaded and does not pair that well with "shareable". Maybe "unique"?
Andreas Kling
Comment 10 2013-02-13 12:20:04 PST
Created attachment 188144 [details] Patch Yeah okay, "Unique" is nice.
Andreas Kling
Comment 11 2013-02-13 13:51:50 PST
Committed r142791: <http://trac.webkit.org/changeset/142791>
Note You need to log in before you can comment on or make changes to this bug.