Bug 109508

Summary: WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: bajones, dino, gman, ojan.autocc, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch kbr: review+

Description Kenneth Russell 2013-02-11 15:59:13 PST
It's been pointed out by Evan Parker from the MapsGL team that getExtension("WEBGL_compressed_texture_s3tc") is returning a non-null value even when the underlying hardware doesn't support the extension. A supports() check in getExtension is missing.
Comment 1 Zhenyao Mo 2013-02-11 16:28:13 PST
Created attachment 187716 [details]
Patch
Comment 2 Kenneth Russell 2013-02-11 16:31:24 PST
Comment on attachment 187716 [details]
Patch

Thanks for the quick fix. Looks good. Note for the record that this will eventually be covered by the WebGL conformance tests Gregg Tavares is in the process of importing.
Comment 3 WebKit Review Bot 2013-02-11 16:32:46 PST
Attachment 187716 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp']" exit_code: 1
Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2409:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2410:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Zhenyao Mo 2013-02-11 16:32:56 PST
Committed r142545: <http://trac.webkit.org/changeset/142545>