Bug 109502

Summary: Fold HTMLTokenizerState back into HTMLTokenizer now that MarkupTokenizerBase is RFG
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107522    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2013-02-11 15:28:05 PST
Fold HTMLTokenizerState back into HTMLTokenizer now that MarkupTokenizerBase is RFG
Attachments
Patch (41.59 KB, patch)
2013-02-11 15:28 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-02-11 15:28:51 PST
Created attachment 187698 [details] Patch
WebKit Review Bot
Comment 2 2013-02-11 15:36:23 PST
Comment on attachment 187698 [details] Patch Rejecting attachment 187698 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 187698, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: urce/WebCore/html/parser/HTMLTokenizer.h Hunk #2 FAILED at 120. Hunk #3 FAILED at 207. Hunk #4 FAILED at 245. 3 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/html/parser/HTMLTokenizer.h.rej patching file Source/WebCore/html/parser/HTMLTreeBuilder.cpp patching file Source/WebCore/html/parser/TextViewSourceParser.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Tony Gentilcore']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16485608
Eric Seidel (no email)
Comment 3 2013-02-11 15:39:51 PST
depends on bug 109499
WebKit Review Bot
Comment 4 2013-02-11 16:55:23 PST
Comment on attachment 187698 [details] Patch Clearing flags on attachment: 187698 Committed r142552: <http://trac.webkit.org/changeset/142552>
WebKit Review Bot
Comment 5 2013-02-11 16:55:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.