Bug 109490
| Summary: | webkit-patch's --reviewer flag should automatically convert emails to full names | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michelangelo De Simone <michelangelo> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | alancutter, dpranke, eric, jchaffraix, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Michelangelo De Simone
When landing with land-safely --reviewer="SOMETHING" the SOMETHING token seems to be taken literally.
TO REPRODUCE:
Try to land a patch with webkit-patch land-safely --reviewer="somereviewer@webkit.org"
WHAT HAPPENS:
The ChangeLogs are populated with "Reviewed by somereviewer@webkit.org"
WHAT SHOULD HAPPEN INSTEAD
A reverse look-up of the --reviewer flag content should take place, populating the ChangeLogs with reviewer's FULL NAME.
NOTES:
For a picture of a great moment take a look at https://bugs.webkit.org/show_bug.cgi?id=106927
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |