Bug 109483

Summary:

Fold MarkupTokenBase into HTMLToken now that it has no other subclasses

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dbates, ojan.autocc, tonyg, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

107522

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Eric Seidel (no email)

Reported 2013-02-11 13:36:28 PST

Fold MarkupTokenBase into HTMLToken now that it has no other subclasses

Attachments
Patch (31.54 KB, patch) 2013-02-11 13:38 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (91.97 KB, patch) 2013-02-11 13:48 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (31.47 KB, patch) 2013-02-11 14:05 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (31.47 KB, patch) 2013-02-11 14:05 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2013-02-11 13:38:10 PST

Created attachment 187655 [details] Patch

Adam Barth

Comment 2 2013-02-11 13:42:30 PST

Comment on attachment 187655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187655&action=review > Source/WebCore/html/parser/HTMLToken.h:108 > + /* Range and offset methods exposed for HTMLSourceTracker and HTMLViewSourceParser */ C++ style comments? > Source/WebCore/html/parser/HTMLToken.h:157 > + /* DOCTYPE Tokens */ C++ comments...

Eric Seidel (no email)

Comment 3 2013-02-11 13:44:43 PST

Comment on attachment 187655 [details] Patch I will take this under careful advisement.

Early Warning System Bot

Comment 4 2013-02-11 13:45:53 PST

Comment on attachment 187655 [details] Patch Attachment 187655 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16491400

Eric Seidel (no email)

Comment 5 2013-02-11 13:48:51 PST

Created attachment 187660 [details] Patch for landing

WebKit Review Bot

Comment 6 2013-02-11 13:57:39 PST

Comment on attachment 187660 [details] Patch for landing Rejecting attachment 187660 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 187660, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: /track/WebVTTTokenizer.h.rej patching file Source/WebCore/xml/parser/MarkupTokenBase.h rm 'Source/WebCore/xml/parser/MarkupTokenBase.h' patching file Source/WebCore/xml/parser/MarkupTokenizerBase.h Hunk #1 FAILED at 28. Hunk #2 FAILED at 55. Hunk #3 FAILED at 206. 3 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/xml/parser/MarkupTokenizerBase.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16487483

Eric Seidel (no email)

Comment 7 2013-02-11 14:05:24 PST

Created attachment 187663 [details] Patch for landing

Eric Seidel (no email)

Comment 8 2013-02-11 14:05:42 PST

Created attachment 187664 [details] Patch for landing

WebKit Review Bot

Comment 9 2013-02-11 15:02:15 PST

Comment on attachment 187664 [details] Patch for landing Clearing flags on attachment: 187664 Committed r142522: <http://trac.webkit.org/changeset/142522>

WebKit Review Bot

Comment 10 2013-02-11 15:02:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.