Bug 109481

Summary: Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, gyuyoung.kim, kinuko, laszlo.gombos, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Zan Dobersek 2013-02-11 13:28:52 PST
Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Comment 1 Zan Dobersek 2013-02-11 13:31:38 PST
Created attachment 187652 [details]
Patch
Comment 2 Laszlo Gombos 2013-02-11 14:19:06 PST
Comment on attachment 187652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review

Overall looks good.

> Tools/Scripts/webkitperl/FeatureList.pm:-481
> -    { option => "xhr-response-blob", desc => "Toggle XHR Response BLOB support",
> -      define => "ENABLE_XHR_RESPONSE_BLOB", default => isBlackBerry(), value => \$xhrResponseBlobSupport },
> -

I thing there is one more spot where xhrResponseBlobSupport is listed in FeatureList.pm.
Comment 3 Laszlo Gombos 2013-02-11 15:48:20 PST
(In reply to comment #2)
> (From update of attachment 187652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review

> I thing there 

I think  .. :-)
Comment 4 Zan Dobersek 2013-02-12 01:43:13 PST
Comment on attachment 187652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review

>> Tools/Scripts/webkitperl/FeatureList.pm:-481
>> -
> 
> I thing there is one more spot where xhrResponseBlobSupport is listed in FeatureList.pm.

Ah, you're right. Will fix that.
Comment 5 Zan Dobersek 2013-02-12 01:54:32 PST
Created attachment 187810 [details]
Patch
Comment 6 Zan Dobersek 2013-02-12 03:07:48 PST
Comment on attachment 187810 [details]
Patch

Clearing flags on attachment: 187810

Committed r142600: <http://trac.webkit.org/changeset/142600>
Comment 7 Zan Dobersek 2013-02-12 03:07:55 PST
All reviewed patches have been landed.  Closing bug.