Bug 109481

Summary: Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, gyuyoung.kim, kinuko, laszlo.gombos, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2013-02-11 13:28:52 PST
Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Attachments
Patch (6.46 KB, patch)
2013-02-11 13:31 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.57 KB, patch)
2013-02-12 01:54 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-02-11 13:31:38 PST
Created attachment 187652 [details] Patch
Laszlo Gombos
Comment 2 2013-02-11 14:19:06 PST
Comment on attachment 187652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review Overall looks good. > Tools/Scripts/webkitperl/FeatureList.pm:-481 > - { option => "xhr-response-blob", desc => "Toggle XHR Response BLOB support", > - define => "ENABLE_XHR_RESPONSE_BLOB", default => isBlackBerry(), value => \$xhrResponseBlobSupport }, > - I thing there is one more spot where xhrResponseBlobSupport is listed in FeatureList.pm.
Laszlo Gombos
Comment 3 2013-02-11 15:48:20 PST
(In reply to comment #2) > (From update of attachment 187652 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review > I thing there I think .. :-)
Zan Dobersek
Comment 4 2013-02-12 01:43:13 PST
Comment on attachment 187652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review >> Tools/Scripts/webkitperl/FeatureList.pm:-481 >> - > > I thing there is one more spot where xhrResponseBlobSupport is listed in FeatureList.pm. Ah, you're right. Will fix that.
Zan Dobersek
Comment 5 2013-02-12 01:54:32 PST
Created attachment 187810 [details] Patch
Zan Dobersek
Comment 6 2013-02-12 03:07:48 PST
Comment on attachment 187810 [details] Patch Clearing flags on attachment: 187810 Committed r142600: <http://trac.webkit.org/changeset/142600>
Zan Dobersek
Comment 7 2013-02-12 03:07:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.