Summary: | [Mac] Track language selection should be sticky | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | dino, feature-media-reviews, gyuyoung.kim, ojan.autocc, philn, pnormand, rakuco, rego+ews, webkit-bug-importer, webkit.review.bot, xan.lopez | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Eric Carlson
2013-02-11 11:31:13 PST
Created attachment 187640 [details]
Proposed patch
Created attachment 187645 [details]
Updated: add missing export to autotools/symbols.filter
Comment on attachment 187645 [details] Updated: add missing export to autotools/symbols.filter View in context: https://bugs.webkit.org/attachment.cgi?id=187645&action=review > Source/autotools/symbols.filter:268 > +_ZN7WebCore9PageGroup18captionPreferencesEv Missing ; at the end of line Created attachment 187654 [details]
Skip the new test on ports that don't have a caption menu
Created attachment 187656 [details]
Add the missing ';'
Philippe, do you know what symbol I need to export for WebCore::Page::initGroup() : ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): In function `WebCore::Internals::resetToConsistentState(WebCore::Page*)': Internals.cpp:(.text+0x3b0c): undefined reference to `WebCore::Page::initGroup()' (In reply to comment #7) > Philippe, do you know what symbol I need to export for WebCore::Page::initGroup() : > > ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): In function `WebCore::Internals::resetToConsistentState(WebCore::Page*)': > Internals.cpp:(.text+0x3b0c): undefined reference to `WebCore::Page::initGroup()' initGroup is: _ZN7WebCore4Page9initGroupEv Created attachment 187671 [details]
Export Page::initGroup.
Comment on attachment 187671 [details] Export Page::initGroup. View in context: https://bugs.webkit.org/attachment.cgi?id=187671&action=review > Source/autotools/symbols.filter:269 > +_ZN7WebCore9PageGroup18captionPreferencesEv; > +_ZN7WebCore4Page9initGroupEv; You don't need to guard these with VIDEO_TRACK like in exp.in? > LayoutTests/media/track/track-user-preferences.html:117 > + createTrackElements([ 'no', 'fr', 'en',]); trailing comma > LayoutTests/media/track/track-user-preferences.html:127 > + createTrackElements([ 'ru', 'jp', 'en',]); trailing comma Committed in http://trac.webkit.org/r142580 |