Bug 109458

Summary:

RunQtAPITests failure of buildbot

Product:

WebKit

Reporter:

Balazs Kilvady <kilvadyb>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

fu, gergely, jturcotte, kadam, ossy, palfia, zarvai

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
proposed patch.	none

Balazs Kilvady

Reported 2013-02-11 09:56:57 PST

Uploaded archive of compiled webkit for Qt contains only /lib and /bin subdirectories while on Qt platform the WebKitBuild/Release/Source/WebKit/qt/tests/ directory is required by RunQtAPITests step. Without adding that directory to the archive on the tester slave we receive the following error: ERROR:Options:Path 'WebKitBuild/Release/Source/WebKit/qt/tests/' doesn't exist

Attachments
proposed patch. (1.34 KB, patch) 2013-02-11 10:05 PST, Balazs Kilvady	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Balazs Kilvady

Comment 1 2013-02-11 10:05:28 PST

Created attachment 187606 [details] proposed patch.

Jocelyn Turcotte

Comment 2 2013-02-11 10:44:59 PST

Comment on attachment 187606 [details] proposed patch. That might be a silly idea, but how about having those tests binaries targetted in bin directly instead of Release/Source/WebKit/qt? This would also make the test binaries easier to run. The issue I see with this patch is that all objects files under Source/WebKit/qt will also be copied in the archive.

Balazs Kilvady

Comment 3 2013-02-11 10:58:54 PST

(In reply to comment #2) > (From update of attachment 187606 [details]) > That might be a silly idea, but how about having those tests binaries targetted in bin directly instead of Release/Source/WebKit/qt? This would also make the test binaries easier to run. > > The issue I see with this patch is that all objects files under Source/WebKit/qt will also be copied in the archive. The .o files won't be in the archive. The script makes a copy of the binaries to compress and leaves out the object files. But I agree. I also think your idea would be better solution or there could be a /bin; /lib/; /qt-test-bin directory structure under Release/Debug directories.

Anders Carlsson

Comment 4 2013-10-02 21:20:49 PDT

Comment on attachment 187606 [details] proposed patch. Qt has been removed, clearing review flags.

Note You need to log in before you can comment on or make changes to this bug.